Add proper revert message on overflow of totalSupply during burn (#3144)

574f3b89 · Hadrien Croubois · GitHub · ca755ce7 · 574f3b89
Unverified Commit 574f3b89 authored Feb 01, 2022 by Hadrien Croubois Committed by GitHub Feb 01, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletions

ERC1155Supply.sol contracts/token/ERC1155/extensions/ERC1155Supply.sol +7 -1

No files found.
--- a/contracts/token/ERC1155/extensions/ERC1155Supply.sol
+++ b/contracts/token/ERC1155/extensions/ERC1155Supply.sol
@@ -51,7 +51,13 @@ abstract contract ERC1155Supply is ERC1155 {

        if (to == address(0)) {
            for (uint256 i = 0; i < ids.length; ++i) {
-                _totalSupply[ids[i]] -= amounts[i];
+                uint256 id = ids[i];
+                uint256 amount = amounts[i];
+                uint256 supply = _totalSupply[id];
+                require(supply >= amount, "ERC1155: burn amount exceeds totalSupply");
+                unchecked {
+                    _totalSupply[id] = supply - amount;
+                }
            }
        }
    }