Commit 4fc6bb79 by Francisco Giordano

remove token.finishMinting() from default finalization

parent e6a7a978
...@@ -16,8 +16,10 @@ contract FinalizableCrowdsale is Crowdsale, Ownable { ...@@ -16,8 +16,10 @@ contract FinalizableCrowdsale is Crowdsale, Ownable {
event Finalized(); event Finalized();
// should be called after crowdsale ends, to do /**
// some extra finalization work * @dev Must be called after crowdsale ends, to do some extra finalization
* work. Calls the contract's finalization function.
*/
function finalize() onlyOwner { function finalize() onlyOwner {
require(!isFinalized); require(!isFinalized);
require(hasEnded()); require(hasEnded());
...@@ -28,12 +30,11 @@ contract FinalizableCrowdsale is Crowdsale, Ownable { ...@@ -28,12 +30,11 @@ contract FinalizableCrowdsale is Crowdsale, Ownable {
isFinalized = true; isFinalized = true;
} }
// end token minting on finalization /**
// override this with custom logic if needed * @dev Can be overriden to add finalization logic. The overriding function
* should call super.finalization() to ensure the chain of finalization is
* executed entirely.
*/
function finalization() internal { function finalization() internal {
token.finishMinting();
} }
} }
...@@ -60,11 +60,4 @@ contract('FinalizableCrowdsale', function ([_, owner, wallet, thirdparty]) { ...@@ -60,11 +60,4 @@ contract('FinalizableCrowdsale', function ([_, owner, wallet, thirdparty]) {
should.exist(event) should.exist(event)
}) })
it('finishes minting of token', async function () {
await increaseTimeTo(this.afterEndTime)
await this.crowdsale.finalize({from: owner})
const finished = await this.token.mintingFinished()
finished.should.equal(true)
})
}) })
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment