- 13 Nov, 2016 4 commits
-
-
Fix binding tests leaking process values
Michael Mifsud authored -
Marvin Hagemeister authored
-
npm config values are strings
xzyfer authored -
xzyfer authored
-
- 12 Nov, 2016 3 commits
-
-
Add descendent files to watched files
Michael Mifsud authored -
The state leakage means that running mocha in watch mode causes random failures. Closes #1748
xzyfer authored -
xzyfer authored
-
- 11 Nov, 2016 1 commit
-
-
Change console.log to npmlog
David Gasperoni authored
-
- 08 Nov, 2016 1 commit
-
-
Fixes #1731
Marvin Hagemeister authored
-
- 07 Nov, 2016 4 commits
-
-
- don't test old Node.JS version on OSX - don't test iojs, should be covered by 0.12 and 4
xzyfer authored -
Stop messing with require.cache in tests
Michael Mifsud authored -
xzyfer authored
-
This removes the need to mess with `require.cache` in tests to test the unsupported platform error message. I've run into issues a couple times related to messing with the require cache.
xzyfer authored
-
- 06 Nov, 2016 1 commit
-
-
xzyfer authored
-
- 05 Nov, 2016 5 commits
-
-
xzyfer authored
-
xzyfer authored
-
xzyfer authored
-
Fix proxy config for binary download
Michael Mifsud authored -
In #1725 we started setting `proxy: ''` to defer proxy resolution logic to request. However `request` uses `hasOwnProperty` rather than falsey checks to determine if an option has been set. This caused `request` to believe were configuring a proxy so it didn't do it's own proxy resolution. Fixes #1785 Fixes #1787
xzyfer authored
-
- 03 Nov, 2016 4 commits
-
-
Update supported node versions
Michael Mifsud authored -
#1766
Anibal authored -
xzyfer authored
-
- 02 Nov, 2016 5 commits
-
-
xzyfer authored
-
Fix links in troubleshooting.md
Michael Mifsud authored -
Respect NO_PROXY when downloading the binary
Michael Mifsud authored -
xzyfer authored
-
Turns our handling proxies is complicated. The sanest thing to do is try matching [npm's behaviour][1], and liable [to change][1] to our benefit. The TLDR; of which is to let `request` do whatever it wants unless npm has been explicitly configured otherwise. Fixes #1724 [1]: https://github.com/npm/npm/commit/40afd6aaf34 [2]: https://github.com/npm/npm/issues/7168
xzyfer authored
-
- 25 Oct, 2016 1 commit
-
-
xzyfer authored
-
- 19 Oct, 2016 1 commit
-
-
Nicolai Søborg authored
-
- 12 Oct, 2016 1 commit
-
-
Fix process argument binary configuration example
Michael Mifsud authored
-
- 11 Oct, 2016 1 commit
-
-
Should be --sass-binary-site instead of --SASS_BINARY_SITE
Paul Selden authored
-
- 03 Oct, 2016 4 commits
-
-
This was removed #1733 but was depended on by #1714.
xzyfer authored -
User configurable cache folder for binary download
Michael Mifsud authored -
Adding unit test coverage to install
Michael Mifsud authored -
The installer is getting more complicated. The core of it is a http request which makes testing it difficult/messy. Pulling out core logic into small util functions that we can unit test would give me much more confidence moving forward. I would prefer we don't export functions from scripts so people don't start relying on undocumented APIs. This is why I opted for helper utils but I'm not committed to them.
xzyfer authored
-
- 02 Oct, 2016 1 commit
-
-
New order of operations 1. Look for existing binary in vendor folder 2. Create target vendor folder 3. Look to see if we’ve cached a copy in the configured or NPM cache 4. Download to current version’s /CACHE/node-sass/version/binding_file 5. Copy the cached download to the regular vendor directory Closes #1566
Nick Schonning authored
-
- 30 Sep, 2016 3 commits