- 01 Sep, 2016 2 commits
-
-
Forked from #1649. This PR adds a small ascii progress bar to the binary download. Stalled installations make up a steady background noise of our issues. It's my hope that by making the binary fetch more transparent we can stem the tide of those issues. In order to address @saper's [concerns][1] this progress bar will respect npm's `progress` config flag. Downloading ``` Start downloading binary at https://github.com/sass/node-sass/releases/download/v3.8.0/darwin-x64-48_binding.node Total 2602136 [=============== ] 1566256 60% 4.9s ``` Success ``` Start downloading binary at https://github.com/sass/node-sass/releases/download/v3.8.0/darwin-x64-48_binding.node Total 2602136 [=========================] 2602136 100% 0.0s Binary downloaded and installed at /tmp/node-sass/vendor/darwin-x64-48/binding.node ``` [1]: https://github.com/sass/node-sass/pull/1649#issuecomment-242720257
Skylar.Zheng authored -
Retry CLI specs that fail three times
Michael Mifsud authored
-
- 31 Aug, 2016 3 commits
-
-
For some reason our test fail due to timeouts on seemingly random cli tests. This instability has been growing worse. I've spent the better part of the last two days looking into the issue without a resolution. I'm starting to think it's an artefact cause by the virtualisation used in CI, potentially related to resources starvation. The specs that fail do so trying to spawn a child process. The process never spawns eventually resulting in a timeout. This is why @nschonni attempt at addressing this by increasing the timeout in Since the spawn failure is random, and catastrophic the best solution I can think of in the short-medium term is to instruct mocha to retry failing tests individually a couple times. I've scoped this behaviour to the cli specs because at the moment we have some specs that are not reentrant.
xzyfer authored -
This PR adds a timeout to the binary fetch request as well as a useful error message. It came to light in #1690 that the download can block for a long time. ``` npm info lifecycle node-sass@3.8.0~install: node-sass@3.8.0 > node-sass@3.8.0 install /Usersproject-path/node_modules/node-sass > node scripts/install.js Build timed out (after 35 minutes). Marking the build as failed. ``` We see a fair amount of hung installer issues that could be related to this. The error output will give us another data point in those cases.
Michael Mifsud authored -
This PR adds a timeout to the binary fetch request as well as a useful error message. It came to light in #1690 that the download can block for a long time. ``` npm info lifecycle node-sass@3.8.0~install: node-sass@3.8.0 > node-sass@3.8.0 install /Usersproject-path/node_modules/node-sass > node scripts/install.js Build timed out (after 35 minutes). Marking the build as failed. ``` We see a fair amount of hung installer issues that could be related to this. The error output will give us another data point in those cases.
xzyfer authored
-
- 26 Aug, 2016 2 commits
-
-
Marcin Cieślak authored
-
- New function buildIncludePaths to build the includePaths string for passing through to libsass - In buildIncludePaths, check for SASS_PATH environment variable, and if found include them behind any other specified include-paths - Add two tests to `.render(options, callback)`: - "should check SASS_PATH in the specified order" - "should prefer include path over SASS_PATH"
Robin Winslow authored
-
- 21 Aug, 2016 3 commits
-
-
libsass_ext is not defined
Marcin Cieślak authored -
Troubleshooting: Check COMSPEC for Windows
Marcin Cieślak authored -
Marcin Cieślak authored
-
- 17 Aug, 2016 1 commit
-
-
Nick Schonning authored
-
- 16 Aug, 2016 1 commit
-
-
Looks like I accidentally reverted my fix while rebasing d6cd0134
Nick Schonning authored
-
- 10 Aug, 2016 1 commit
-
-
Nick Schonning authored
-
- 09 Aug, 2016 1 commit
-
-
ESLint conversion from JSHint
Nick Schonning authored
-
- 20 Jul, 2016 1 commit
-
-
Marcin Cieślak authored
-
- 17 Jul, 2016 2 commits
-
-
Marcin Cieślak authored
-
Fixes: https://github.com/sass/node-sass/pull/1631 Fixes: https://github.com/electron/electron/issues/6462 Broken-By: https://github.com/sass/node-sass/pull/1101 Fix-Provided-By: https://github.com/sass/node-sass/pull/1631
Marcin Cieślak authored
-
- 14 Jul, 2016 5 commits
-
-
Suppressed the ones coming from the Sass Types
Nick Schonning authored -
Nick Schonning authored
-
Newer rule system and auto-fixing errors
Nick Schonning authored
- 05 Jul, 2016 1 commit
-
-
We don't use gitter anymore,
Michael Mifsud authored
-
- 16 Jun, 2016 2 commits
- 15 Jun, 2016 1 commit
-
-
The options object passed into `render` and `renderSync` is only shallow copied. This is an issue when nested objects and arrays like custom importer and functions. In the case of custom function we wrap the provided function. This wrapped version replaces the provided one which can then leak back into the calling code. This is an issue if `render*` is called in a loop like in gulp-sass. Fixes #1168
Michael Mifsud authored
-
- 10 Jun, 2016 2 commits
-
-
Chore: Fix Coveralls conditional for Travis-CI
Nick Schonning authored -
Nick Schonning authored
-
- 08 Jun, 2016 2 commits
-
-
Broken when switching from the old matrix to the built in node_js version
Nick Schonning authored -
* In watch mode, play an audible cue when there is an error. * Added error-bell option. * Added error-bell option to documentation.
PeterHatch authored
-
- 31 May, 2016 1 commit
-
-
Both packages have been merged and cross-spawn is now doing the same as cross-spawn-async before
Daniel Tschinder authored
-
- 10 May, 2016 1 commit
-
-
Currently we build the Sass import graph when the CLI watcher is started. However the graph is not update updated when files are added or deleted. The latest is a big deal but the former results in new files not triggered rebuilds when they're changed. The only way to currently resolve this is to restart the CLI watcher. This patch rebuilds the Sass import graph when files are added or deleted to the watch always works as expected. Fixes #1538
Michael Mifsud authored
-
- 05 May, 2016 1 commit
-
-
Renamed parameters to be a little clearer, and marked them public since they are being exported
Nick Schonning authored
-
- 03 May, 2016 2 commits
-
-
For the lazy
Michael Mifsud authored -
The support was added in sass/node-sass#1499
Markus Tacker authored
-
- 02 May, 2016 4 commits
-
-
Currently it's a bit of an ordeal trying to get the atomic puush required for AppVeyor to register a commit on the release branch and also a tag. Looks like AppVeyor expects you to do release from the master branch. Inspired by @nschonni work in #1518 in an attempt to work around this issue this PR instructs AppVeyor to ignore tags on non-release branches. Fingers crossed this makes like easier. Closes #1518
Michael Mifsud authored -
xzyfer authored
-
Closes #1486
Michael Mifsud authored -
Node 6.x has trouble including modules from MS-DOS drives created with subst.exe. Since we use use subst only to set symbols paths in the PDB file, let's revert to the C: drive when doing tests. Workaround for: https://github.com/nodejs/node/issues/6500
Marcin Cieślak authored
-
- 29 Apr, 2016 1 commit
-
-
Previous we manually installed NVM and did the version switching ourselves. This was required because Trvais didn't support NVM on OSX builds. This has since [been fixed][1] so lets see how it goes. [1:][https://github.com/travis-ci/travis-ci/issues/2311]
Michael Mifsud authored
-