- 04 Apr, 2018 1 commit
-
-
This is an alternative to some of the fixes in [1]. Starting with Nan 2.9.0, we have the ability to propagate async context across async hops. Certain variants of Nan::Callback::Call are now deprecated to encourage use of the context presevering alternatives. Certain variants of Node's MakeCallback that were used internally are going to be deprecated in Node 10. Summary is that one should use Nan::Call for sync calls, and Nan::Callback::Call for async. The latter expects an async resource corresponding to the async operation to be provided at the call time. This patch fixes things up so that 1) node-sass isn't using any deprecated APIs, and 2) properly propagates async context for async callbacks by creating async resources in the appropriate places. [1]: https://github.com/sass/node-sass/pull/2295
Ali Ijaz Sheikh authored
-
- 03 Apr, 2018 1 commit
-
-
刘祺 authored
-
- 29 Mar, 2018 1 commit
-
-
Nick Schonning authored
-
- 17 Mar, 2018 7 commits
-
-
Michael Mifsud authored
-
Benjamin Byholm authored
-
Benjamin Byholm authored
-
Benjamin Byholm authored
-
Benjamin Byholm authored
-
Work around https://github.com/nodejs/nan/issues/755
xzyfer authored -
Fixes #2287
xzyfer authored
-
- 13 Mar, 2018 2 commits
- 11 Mar, 2018 3 commits
- 10 Mar, 2018 8 commits
-
-
xzyfer authored
-
xzyfer authored
-
Currently the binary download is streamed to disk once a 200 response has been recieved. When an error occurs during the download a partially downloaded binary is left on disk. Subsequent installs see the binary and bail out of re-downloading it. Worse yet those subsequent installs move the binary into the global cache so even removing node_modules will not remove the broken binary. With this patch the binary is only flushed to disk once it has been fully downloaded. Fixes #1882 Fixes #1888
xzyfer authored -
Kristaps Austers authored
-
Kristaps Austers authored
-
Updated the node-sass cli script to use the watcher removed function instead of the 'deleted' function which is non-existent.
William authored -
Lets try to avoid the rush of issues when Node 10 is released next month. Node 10 is currently version [`62`][1] but is expected to be [`63`][2] before going stable. We need to pick one because of the ABI breakage betweem 62 and 63. If this bet pays off we save ourselves a bunch of time dealing with installation issues, and avoiding a new release. If we're wrong it's no different to any other major Node release. [1]: https://github.com/nodejs/node/blob/97595739/src/node_version.h#L112 [2]: https://github.com/nodejs/node/pull/19201
xzyfer authored -
I ran into [an issue][1] compiling the iojs 3 binary on OSX. This sound affect anyone in reality but just in case. [1]: https://github.com/nodejs/nan/pull/728
xzyfer authored
-
- 07 Mar, 2018 3 commits
-
-
Jimmy King authored
-
xzyfer authored
-
- 04 Mar, 2018 2 commits
- 24 Feb, 2018 1 commit
-
-
Saw this trick in another repo and though it made sense
Nick Schonning authored
-
- 22 Feb, 2018 1 commit
-
-
We still want these till we officially drop the EOL Node versions
Nick Schonning authored
-
- 20 Feb, 2018 1 commit
-
-
In this way his past contributions are mapped correctly, including collapsing two different ways of writing "ę" into one.
Michał Gołębiowski-Owczarek authored
-
- 17 Jan, 2018 1 commit
-
-
Andrew Luca authored
-
- 23 Dec, 2017 1 commit
-
-
Fixed a Typo
Saul Ivan Rivas Vega authored
-
- 20 Nov, 2017 2 commits
-
-
xzyfer authored
-
Related https://github.com/barsh/true-case-path/issues/2 Fixes #2157 Closes #2161
xzyfer authored
-
- 17 Nov, 2017 3 commits
- 16 Nov, 2017 2 commits
-
-
Nick Schonning authored
-
xzyfer authored
-