Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
node-sass
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
楚学文
node-sass
Commits
162091e7
Commit
162091e7
authored
Dec 27, 2015
by
Michael Mifsud
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1318 from xzyfer/fix/importer-async-null
Handle sass.NULL returned from the importer via done()
parents
31d54cb9
99dc18c4
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
20 additions
and
9 deletions
+20
-9
index.js
lib/index.js
+8
-8
api.js
test/api.js
+12
-1
No files found.
lib/index.js
View file @
162091e7
...
...
@@ -301,27 +301,27 @@ module.exports.render = function(options, cb) {
if
(
Array
.
isArray
(
importer
))
{
importer
.
forEach
(
function
(
subject
,
index
)
{
options
.
importer
[
index
]
=
function
(
file
,
prev
,
bridge
)
{
function
done
(
data
)
{
bridge
.
success
(
data
);
function
done
(
result
)
{
bridge
.
success
(
result
===
module
.
exports
.
NULL
?
null
:
result
);
}
var
result
=
subject
.
call
(
options
.
context
,
file
,
prev
,
done
);
if
(
result
)
{
done
(
result
===
module
.
exports
.
NULL
?
null
:
result
);
if
(
result
!==
undefined
)
{
done
(
result
);
}
};
});
}
else
{
options
.
importer
=
function
(
file
,
prev
,
bridge
)
{
function
done
(
data
)
{
bridge
.
success
(
data
);
function
done
(
result
)
{
bridge
.
success
(
result
===
module
.
exports
.
NULL
?
null
:
result
);
}
var
result
=
importer
.
call
(
options
.
context
,
file
,
prev
,
done
);
if
(
result
)
{
done
(
result
===
module
.
exports
.
NULL
?
null
:
result
);
if
(
result
!==
undefined
)
{
done
(
result
);
}
};
}
...
...
test/api.js
View file @
162091e7
...
...
@@ -325,6 +325,17 @@ describe('api', function() {
});
});
it
(
'should fallback to default import behaviour if importer returns sass.NULL'
,
function
(
done
)
{
sass
.
render
({
file
:
fixture
(
'include-files/index.scss'
),
importer
:
function
(
url
,
prev
,
done
)
{
done
(
sass
.
NULL
);
}
},
function
(
error
,
result
)
{
assert
.
equal
(
result
.
css
.
toString
().
trim
(),
'/* foo.scss */
\
n/* bar.scss */'
);
done
();
});
});
it
(
'should fallback to default import behaviour if importer returns null for backwards compatibility'
,
function
(
done
)
{
sass
.
render
({
...
...
@@ -1010,7 +1021,7 @@ describe('api', function() {
return
sass
.
types
.
String
(
'foo'
);
},
bar
:
function
(
a
)
{
assert
.
strictEqual
(
a
,
sass
.
NULL
,
assert
.
strictEqual
(
a
,
sass
.
NULL
,
'Supplied value should be the same instance as sass.NULL'
);
assert
.
throws
(
function
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment